[PATCH] D60031: Split tailcallelim into tailcallmark and tailcallelim

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 12:29:32 PDT 2019


jdoerfert added a comment.

In D60031#1452642 <https://reviews.llvm.org/D60031#1452642>, @uenoku wrote:

> Yes, the problem is PR41047. Inserting tailcallmark after memcpyopt would solve this problem.
>
> Will you have a plan to make Attributor mark "tail"? If so, I think it is better to leave marking to Attributor.


My main point is that you did not move tailcallmark after memcpyopt, correct?

If we want to change how/when tail is deduced is a separate discussion I guess. Keeping the existing deduction is the right thing for the patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60031/new/

https://reviews.llvm.org/D60031





More information about the llvm-commits mailing list