[PATCH] D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VecFuncs.def:13
+
+#if defined(TLI_DEFINE_VECDESCS)
+#define TLI_DEFINE_VECFUNC(SCAL, VEC, VF) {SCAL, VEC, VF},
----------------
Why we want to check `TLI_DEFINE_VECDESCS` to define `TLI_DEFINE_VECFUNC`?
Can't we just check `#ifndef TLI_DEFINE_VECFUNC` here?


================
Comment at: llvm/include/llvm/Analysis/VecFuncs.def:174
+#undef TLI_DEFINE_VECFUNC
+#undef TLI_DEFINE_ACCELERATE_VECFUNCS
+#undef TLI_DEFINE_SVML_VECFUNCS
----------------
This is not always defined, should we call `#undef` when we are sure they are defined?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60211/new/

https://reviews.llvm.org/D60211