[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

Wed Apr 3 11:26:40 PDT 2019

The windows bot is broken now - the test that you disabled is passing after your latest change, so the bot is failing because of the unexpected pass.

-----Original Message-----
From: lldb-commits <lldb-commits-bounces at lists.llvm.org> On Behalf Of Greg Clayton via lldb-commits
Sent: Wednesday, April 3, 2019 9:52 AM
To: reviews+D60001+public+38c1c2a8960dbf13 at reviews.llvm.org
Cc: lldb-commits <lldb-commits at lists.llvm.org>; Pavel Labath via llvm-commits <llvm-commits at lists.llvm.org>; Mark Mentovai <mark at chromium.org>; javed.absar at arm.com; ah841814092 at gmail.com
Subject: Re: [Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

So I resubmitted with 357603 and green dragon seems happy. I will continue to watch for any issues. Let me know if there are other failures that I don't know about

> On Apr 2, 2019, at 11:57 AM, Adrian Prantl via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> aprantl added a comment.
> 
> Since this commit, TestMiniDumpUUID_py is failing on green dragon.
> 
> Could you please revert the change or commit a fix?
> 
> https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgreen.lab.llvm.org%2Fgreen%2Fview%2FLLDB%2Fjob%2Flldb-cmake%2FlastCompletedBuild%2FtestReport%2Flldb-Suite%2Ffunctionalities_postmortem_minidump-new%2FTestMiniDumpUUID_py%2F&data=02%7C01%7CSTILIS%40microsoft.com%7C2329713f4f564cfcaf6708d6b854bd95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899071433931243&sdata=PfgzlJSZeBz%2F5%2FLww5eGSe6mr8OpGaMH5F2hAVKoTYc%3D&reserved=0
> 
> 
> Repository:
>  rL LLVM
> 
> CHANGES SINCE LAST ACTION
>  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD60001%2Fnew%2F&data=02%7C01%7CSTILIS%40microsoft.com%7C2329713f4f564cfcaf6708d6b854bd95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899071433931243&sdata=LYuIiGWVVxMz7pzX%2F6l%2FU6EvuvwxIrs%2FvAI%2BHwYjF5U%3D&reserved=0
> 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD60001&data=02%7C01%7CSTILIS%40microsoft.com%7C2329713f4f564cfcaf6708d6b854bd95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899071433931243&sdata=8BnqMpUrVUK2ZDqcDJMM4vG7uOrogq8YPoaGKEJWqtw%3D&reserved=0
> 
> 
> 

_______________________________________________
lldb-commits mailing list
lldb-commits at lists.llvm.org
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Flldb-commits&data=02%7C01%7CSTILIS%40microsoft.com%7C2329713f4f564cfcaf6708d6b854bd95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636899071433931243&sdata=r8I5uysu5v4V0S%2FF8xcwpr7MEuqwAivfSL9XfQqcKbs%3D&reserved=0