[PATCH] D60039: Fix the bug of garbage collection of siod.

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

I would question whether it's actually worth it to attempt to keep software working that seems to have been abandoned for a decade as part of the llvm test suite? Should this code just be removed, instead of patched?

I'd note that not all platforms support getcontext -- at least Windows and OpenBSD don't. I don't actually know if this is expected to work on those platforms, but it definitely won't after this change.



================
Comment at: MultiSource/Applications/siod/slib.c:132
 struct gc_protected *protected_registers = NULL;
-jmp_buf save_regs_gc_mark;
+ucontext_t ucontext;
 double gc_rt;
----------------
Renaming the global seems unfortunate; "save_regs_gc_mark" was a more descriptive name than "ucontext".


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60039/new/

https://reviews.llvm.org/D60039