[PATCH] D60134: [llvm-nm]Add support for --no-demangle

Wed Apr 3 09:40:41 PDT 2019

rupprecht added a comment.

In D60134#1452819 <https://reviews.llvm.org/D60134#1452819>, @jhenderson wrote:

> In D60134#1452806 <https://reviews.llvm.org/D60134#1452806>, @jhenderson wrote:
>
> > In D60134#1452786 <https://reviews.llvm.org/D60134#1452786>, @grimar wrote:
> >
> > > And this patch implements the correct behavior of the normal option the first time it seems.
> >
> >
> > Thanks. I took the behaviour from --no-demangle in llvm-symbolizer, so I can't exactly take all the credit!
>
>
> We spoke too soon. Updating the test as @rupprecht suggested highlighted an issue where the switches cannot appear multiple times on the command-line. There's no good reason why they shouldn't (aside from tidiness), and I have encountered build systems and scripts where appending options to an existing command-line is about the only choice available, even if it means duplicate options, so we should allow multiple occurrences. I'll update the patch accordingly.

Oh, that's weird. Why isn't that the default?
Not necessarily just for this reason, but it would fix it -- we should probably switch the tools to use liboption, which was discussed on the mailing list some time last year. Anyway, what was submitted lgtm.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60134/new/

https://reviews.llvm.org/D60134