[PATCH] D54327: Adding debug info to support Fortran (part 3)

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 08:55:11 PDT 2019


schweitz marked an inline comment as done.
schweitz added a comment.

Thanks, Paul.  I can certainly file a bug after this lands for tracking purposes.

Process question: should this review be updated with the bug information/link?

I'll remove the line in the test ...



================
Comment at: test/DebugInfo/Generic/DICommonBlock.ll:13
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-linux-gnu"
+
----------------
probinson wrote:
> Remove the 'target triple' line so this test will still work on bots that don't build the X86 target.
Thanks for catching that, Paul.  I'll remove that line.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54327/new/

https://reviews.llvm.org/D54327





More information about the llvm-commits mailing list