[PATCH] D60020: [DAGCombiner][X86][SystemZ] Canonicalize SSUBO with immediate RHS to SADDO by negating the immediate.

Wed Apr 3 08:10:15 PDT 2019

uweigand added a comment.

In D60020#1452183 <https://reviews.llvm.org/D60020#1452183>, @craig.topper wrote:

> -Update a SystemZ test I missed cause I only had X86 building previously. I think this one of these cases is a regression, but that's probably also going to happen with the InstCombine version of this patch too. So probably needs to be fixed regardless.

Indeed.  In fact, we see the suboptimal code today when compiling a sadd.with.overflow with the negated constant, so this should be fixed anyway.  I've checked the fix in as rev 357597.

If you rebase against that revision, you should no longer see the regression.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60020/new/

https://reviews.llvm.org/D60020