[PATCH] D60196: [llvm-symbolizer] Add grouping for -e

Wed Apr 3 07:31:07 PDT 2019

jhenderson added a comment.

In D60196#1453157 <https://reviews.llvm.org/D60196#1453157>, @ikudrin wrote:

> In D60196#1453050 <https://reviews.llvm.org/D60196#1453050>, @jhenderson wrote:
>
> > Do you think it's worth testing the behaviour of -e in the middle of a group of options e.g. "-Cefi"?
>
>
> It's a negative scenario, right? Haven't we already checked that in CommandLineTest.GroupingWithValue <https://github.com/llvm/llvm-project/blob/ee737a84d75b701c2ae3a8c9a0abbae63fc330af/llvm/unittests/Support/CommandLineTest.cpp#L1161>?

The issue is that that unit test only tests that options with the specific set of properties are handled in that way, but doesn't show that the -e option has those properties. I'm in two minds about it though, because it clearly takes a value. I guess I'm wondering how we know that "-Cefi" is/isn't equivalent to "-C -e=fi" without inspecting the code.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60196/new/

https://reviews.llvm.org/D60196