[PATCH] D60200: [llvm-objcopy] Make section rename/set flags case-insensitive

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 07:25:23 PDT 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: test/tools/llvm-objcopy/ELF/set-section-flags.test:69
+# RUN: llvm-readobj --sections %t.mixed | FileCheck %s --check-prefixes=CHECK,PROGBITS,ALLOC,EXEC,MERGE,STRINGS
+
 !ELF
----------------
Perhaps separating into two independent blocks would be a bit more readable?

```
# Upper case flags:
# RUN: ...
...

# Mixed-case flags:
# RUN: ...
...
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60200/new/

https://reviews.llvm.org/D60200





More information about the llvm-commits mailing list