[PATCH] D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section

[Xing via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3413
+          VersionName = "(*invalid*)";
+        OS << left_justify(VersionName, 13);
+      }
----------------
jhenderson wrote:
> Higuoxing wrote:
> > jhenderson wrote:
> > > What happens if the version name is longer than this? (Is that even possible?)
> > Yes, it's possible. But `GNU readelf` does not do any improvement here, shall we?
> I think it's okay to leave for now, but you might want to consider improving it in a future version, by using a column width that varies depending on name widths.
Thanks, I will consider improve this behavior


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59877/new/

https://reviews.llvm.org/D59877