[PATCH] D60118: [AArch64][AsmParser] Fix .arch_extension directive parsing

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

> It appears the .cpu, .arch and .arch_extension directives can only enable features defined in ExtensionMap in the AArch64AsmParser.cpp and ignores them otherwise. ExtensionMap seems incomplete, in the patch you mentioned only tlb-rmi, pan-rwv and ccpp features were added.

This whole `ExtensionMap` is a bit of a hack. It's a hack because it duplicates information already described in TargetParser (AArch64TargetParser.def). But this isn't an easy thing to fix I think.

I don't want to hold up this patch, but any low hanging fruit to make this more complete would be a really big bonus. Perhaps an approach is to first complete the tests with extensions already in `ExtensionMap`, that should hopefully just work. And if you feel strong about this, you can then add missing extension in a follow up patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60118/new/

https://reviews.llvm.org/D60118