[PATCH] D60196: [llvm-symbolizer] Add grouping for -e

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin created this revision.
ikudrin added reviewers: jhenderson, rupprecht.
Herald added a project: LLVM.

'addr2line' allows `-e` to be grouped with other options. This patch adds the same for `llvm-symbolizer`.


Repository:
  rL LLVM

https://reviews.llvm.org/D60196

Files:
  test/tools/llvm-symbolizer/flag-grouping.test
  tools/llvm-symbolizer/llvm-symbolizer.cpp


Index: tools/llvm-symbolizer/llvm-symbolizer.cpp
===================================================================
--- tools/llvm-symbolizer/llvm-symbolizer.cpp
+++ tools/llvm-symbolizer/llvm-symbolizer.cpp
@@ -94,10 +94,9 @@
 static cl::alias
 ClBinaryNameAliasExe("exe", cl::desc("Alias for -obj"),
                      cl::NotHidden, cl::aliasopt(ClBinaryName));
-static cl::alias
-ClBinaryNameAliasE("e", cl::desc("Alias for -obj"),
-                   cl::NotHidden, cl::aliasopt(ClBinaryName));
-
+static cl::alias ClBinaryNameAliasE("e", cl::desc("Alias for -obj"),
+                                    cl::Grouping, cl::NotHidden,
+                                    cl::aliasopt(ClBinaryName));
 
 static cl::opt<std::string>
     ClDwpName("dwp", cl::init(""),
Index: test/tools/llvm-symbolizer/flag-grouping.test
===================================================================
--- test/tools/llvm-symbolizer/flag-grouping.test
+++ test/tools/llvm-symbolizer/flag-grouping.test
@@ -1,4 +1,6 @@
 RUN: llvm-symbolizer -apCi -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -apCie %p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -apCie=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
 
 CHECK: some text
 CHECK: 0x40054d: inctwo


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60196.193472.patch
Type: text/x-patch
Size: 1313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190403/6c50a6f8/attachment.bin>