[PATCH] D60122: [yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 3 05:05:29 PDT 2019
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: tools/yaml2obj/yaml2elf.cpp:324
+static size_t findLastLocal(ArrayRef<ELFYAML::Symbol> Symbols) {
+ for (size_t I = 0; I < Symbols.size(); ++I)
----------------
jhenderson wrote:
> Sorry, actually, I think findFirstNonGlobal would be better, now that I think about it!
Yeah, that probably makes more sense. Thanks for the review!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60122/new/
https://reviews.llvm.org/D60122
More information about the llvm-commits
mailing list