[PATCH] D60134: [llvm-nm]Add support for --no-demangle

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 02:19:20 PDT 2019


jhenderson added a comment.

In D60134#1452806 <https://reviews.llvm.org/D60134#1452806>, @jhenderson wrote:

> In D60134#1452786 <https://reviews.llvm.org/D60134#1452786>, @grimar wrote:
>
> > And this patch implements the correct behavior of the normal option the first time it seems.
>
>
> Thanks. I took the behaviour from --no-demangle in llvm-symbolizer, so I can't exactly take all the credit!


We spoke too soon. Updating the test as @rupprecht suggested highlighted an issue where the switches cannot appear multiple times on the command-line. There's no good reason why they shouldn't (aside from tidiness), and I have encountered build systems and scripts where appending options to an existing command-line is about the only choice available, even if it means duplicate options, so we should allow multiple occurrences. I'll update the patch accordingly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60134/new/

https://reviews.llvm.org/D60134





More information about the llvm-commits mailing list