[PATCH] D60122: [yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 3 02:13:40 PDT 2019
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: test/tools/yaml2obj/dynamic-symbols.yaml:25-28
+ - Name: dynlocal
+ Type: STT_OBJECT
+ Section: .data
+ Binding: STB_LOCAL
----------------
jhenderson wrote:
> Why doesn't this cause an error?
We do not have a check for `.dynsym` symbols order. `buildSymbolIndex` is called for `.symtab` only.
I believe `.dynsym` never contains local symbols in a normally produced ELF.
I.e. this test case is kind of a bit broken from start.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60122/new/
https://reviews.llvm.org/D60122
More information about the llvm-commits
mailing list