[PATCH] D60170: [llvm-objcopy] [llvm-symbolizer] Fix failing tests

Wed Apr 3 01:42:15 PDT 2019

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/regex.test:55
-#REGEX2-NOT: foobaz
-#REGEX2: bar
-#REGEX2-NOT: rebar
----------------
Nit: I know this was there before, but would you mind indenting this match, so that it lines up with the other patterns, please?

```
#REGEX2-NOT: Name: foobaz
#REGEX2:     Name: bar
#REGEX2-NOT: Name: rebar
```

================
Comment at: llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s:3
 # RUN: llvm-mc --filetype=obj --triple=x86_64-pc-linux %s -o %t.o -g
-# RUN: llvm-symbolizer --obj=%t.o 0 | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-symbolizer --obj=%t.o 0 | FileCheck %s --implicit-check-not="^bar$"

----------------
Is implicit-check-not a regex pattern or just a literal check (I think it's a literal check)? Does this still fail when bar appears instead of foo?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60170/new/

https://reviews.llvm.org/D60170