[PATCH] D59278: [WebAssembly] Apply data relocations at runtime in shared objects

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/Driver.cpp:283
+  if (!Arg) {
+    if (Args.hasArg(OPT_relocatable))
+      return "";
----------------
ruiu wrote:
> Is the combination of `--entry` and `--relocatable` valid? Maybe we should reject that combination in the driver?
We already do check for this in checkOptions (see `error("entry point specified for relocatable output file")`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59278/new/

https://reviews.llvm.org/D59278