[PATCH] D60170: [llvm-objcopy] [llvm-symbolizer] Fix failing tests

[Don Hinton via Phabricator via llvm-commits]

hintonda created this revision.
hintonda added reviewers: evgeny777, mattd.
Herald added subscribers: rupprecht, MaskRay, jakehehrlich, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

Don't use simple single word strings for matching as they can
match a substring in the path and give erroneous results.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60170

Files:
  llvm/test/tools/llvm-objcopy/ELF/regex.test
  llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s


Index: llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s
===================================================================
--- llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s
+++ llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s
@@ -1,6 +1,6 @@
 # REQUIRES: x86-registered-target
 # RUN: llvm-mc --filetype=obj --triple=x86_64-pc-linux %s -o %t.o -g
-# RUN: llvm-symbolizer --obj=%t.o 0 | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-symbolizer --obj=%t.o 0 | FileCheck %s --implicit-check-not="^bar$"
 
 # CHECK:      foo
 # CHECK-NEXT: ignore-undefined-symbols.s:12:0
Index: llvm/test/tools/llvm-objcopy/ELF/regex.test
===================================================================
--- llvm/test/tools/llvm-objcopy/ELF/regex.test
+++ llvm/test/tools/llvm-objcopy/ELF/regex.test
@@ -47,14 +47,14 @@
       Value:    0x1010
       Size:     8
 
-#REGEX1-NOT: foobaz
-#REGEX1-NOT: bar
-#REGEX1-NOT: rebar
+#REGEX1-NOT: Name: foobaz
+#REGEX1-NOT: Name: bar
+#REGEX1-NOT: Name: rebar
 
-#REGEX2-NOT: foobaz
-#REGEX2: bar
-#REGEX2-NOT: rebar
+#REGEX2-NOT: Name: foobaz
+#REGEX2: Name: bar
+#REGEX2-NOT: Name: rebar
 
-#REGEX3: foobaz
-#REGEX3: bar
-#REGEX3: rebar
+#REGEX3: Name: foobaz
+#REGEX3: Name: bar
+#REGEX3: Name: rebar


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60170.193410.patch
Type: text/x-patch
Size: 1267 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190403/7b55cf7b/attachment.bin>