[PATCH] D60133: [DAGCombiner] Improve detection of unmergable stores, based on type size (WIP)

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 18:03:12 PDT 2019


niravd added a comment.

It's not sufficient to check if you can merge two stores into a valid node; there are backends where you need 4 or more to get a legal merged store.

If you look at target-specific implementations of CanMergeStoresTo it essentially serves as a context-specific find maximum store which is what we need here.  If you massage that interface a bit you can fold most of this check in there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60133/new/

https://reviews.llvm.org/D60133





More information about the llvm-commits mailing list