[PATCH] D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot.

[Taewook Oh via Phabricator via llvm-commits]

twoh added a comment.

@wmi Thank you for the concrete example! I think what we need for your example is context-sensitive profiling and function specialization, not inlining. Admittedly we don't have an infrastructure in LLVM to support context-sensitive profiling for non-inlined case and we don't perform context sensitive function specialization...

Again, my bigger concern is with using `PSI->isHotCount` to check the function hotness. If we want to stay with the function total count based heuristic, wouldn't it make more sense if we have something like `ProfileSummaryInfo::isFunctionHotInCallGraph`, which actually checks the hotness of the function itself, and use it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60086/new/

https://reviews.llvm.org/D60086