[PATCH] D60147: [DWARF] check whether the DIE is valid before querying for information

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 15:52:46 PDT 2019


dblaikie added inline comments.


================
Comment at: llvm/test/DebugInfo/dwarfdump-bad-lookup-address.test:1
+RUN: llvm-dwarfdump -lookup 1161 %p/Inputs/dwarfdump-test.macho-i386.o
----------------
Testing that the program doesn't crash is a fairly broad test (what does it do instead? It could print all sorts of odd/weird/incorrect output while still passing this test) - could you test for the specific output that was hidden behind this crash previously?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60147/new/

https://reviews.llvm.org/D60147





More information about the llvm-commits mailing list