[PATCH] D60154: [PGO] Better handling of profile hash mismatch

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 14:51:18 PDT 2019


xur created this revision.
xur added reviewers: davidxl, vsk.

We currently assume profile hash conflicts will be caught by an upfront check and we assert for the cases that escape the check. The assumption is not always true as there are chances of conflict. This patch prints a warning and skips annotating the function for the escaped cases,.


https://reviews.llvm.org/D60154

Files:
  lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  test/Transforms/PGOProfile/Inputs/select_hash_conflict.proftext
  test/Transforms/PGOProfile/select_hash_conflict.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60154.193368.patch
Type: text/x-patch
Size: 7838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190402/7af861c9/attachment.bin>


More information about the llvm-commits mailing list