[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 14:37:37 PDT 2019


tra added a comment.

In D60141#1452019 <https://reviews.llvm.org/D60141#1452019>, @ashi1 wrote:

> Hi Artem, I had just committed the change. IS this change OK or should I revert it?


The `if` condition could use some clang-formatting, but other than that the patch still looks OK to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60141/new/

https://reviews.llvm.org/D60141





More information about the llvm-commits mailing list