[PATCH] D59152: [libc++] Build <filesystem> support as part of the dylib

[Louis Dionne via Phabricator via llvm-commits]

ldionne marked 2 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/trunk/utils/libcxx/test/config.py:710-713
-        enable_fs = self.get_lit_bool('enable_filesystem', default=False)
-        if not enable_fs:
-            return
-        self.config.available_features.add('c++filesystem')
----------------
tra wrote:
> This appears to break CUDA buildbot:
> http://lab.llvm.org:8011/builders/clang-cuda-build/builds/31842/steps/ninja%20check%201/logs/stdio
> 
> Apparently lit does not find that directory, even though it *is* present in the checked out tree with this config file. I guess lit has somehow misdetected libcxx_src_root, but I see nothing relevant in the logs.
> 
> Any ideas what could be wrong?
No idea what could be wrong, however can you check on the bot whether `<...>/libcxx/test/std/input.output/filesystems/Inputs/static_test_env` exists? This seems to be what `lit` is complaining about.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59152/new/

https://reviews.llvm.org/D59152