[PATCH] D34499: Expose __gcov_flush for parity with libgcov in the gcc project

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Hi @ngie,

Sorry for the delay here. I am hitting two test failures with this patch applied on Darwin. Could you take a look?

  /Users/vsk/src/llvm-project-master/compiler-rt/test/profile/Posix/../Inputs/instrprof-gcov-fork.c.gcov:10:15: error: CHECK-NEXT: expected string not found in input
  // CHECK-NEXT:function func2 called 2 returned 100% blocks executed 100%
                ^
  instrprof-gcov-fork.c.gcov:10:1: note: scanning from here
  function func2 called 1 returned 100% blocks executed 100%
  
  ...
  
  /Users/vsk/src/llvm-project-master/compiler-rt/test/profile/Inputs/instrprof-gcov-__gcov_flush-multiple.c:6:7: warning: implicit declaration of function 'remove' is invalid in C99 [-Wimplicit-function-declaration]
    if (remove("instrprof-gcov-__gcov_flush-multiple.gcda") != 0) {
        ^
  1 warning generated.
  /Users/vsk/src/llvm-project-master/compiler-rt/test/profile/Inputs/instrprof-gcov-__gcov_flush-multiple.c.gcov:6:15: error: CHECK-NEXT: expected string not found in input
  // CHECK-NEXT:    #####:    1:int main(void) {
                ^
  instrprof-gcov-__gcov_flush-multiple.c.gcov:6:9: note: scanning from here
          -:    1:#include <gcov.h>
          ^
  instrprof-gcov-__gcov_flush-multiple.c.gcov:8:5: note: possible intended match here
      #####:    3:int main(void) {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D34499/new/

https://reviews.llvm.org/D34499