[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D32530#1451494 <https://reviews.llvm.org/D32530#1451494>, @huntergr wrote:

> In D32530#1448135 <https://reviews.llvm.org/D32530#1448135>, @sebpop wrote:
>
> > I am accepting the scalable vector types based on the comments in
> >  http://lists.llvm.org/pipermail/llvm-dev/2019-March/131137.html
> >
> > Let's move forward with SVE support in LLVM.  Thanks!
>
>
> Hi Sebastian,
>
> Thanks!
>
> I'll wait a couple more days for last minute feedback before committing.


I'd advise caution here, it's really significant/impactful change, and a single sign-off is a bit worrying.
In particular, even regardless of the feature itself, has the implementation itself been reviewed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530