[PATCH] D60096: [InstCombine] Simplify ctlz/cttz with bitreverse

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 05:58:35 PDT 2019


spatel added a comment.

We don't need a full permutation of the possibilities, but can you add at least a few test variations and improvements:

1. The 2nd param is 'false'.
2. The type is a vector.
3. Run '-instnamer' or manually add variable names, so we don't have nameless values.
4. Pre-commit the baseline versions of the tests.
5. Add a comment/link for PR41273 (should also mention that in the description/commit message).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60096/new/

https://reviews.llvm.org/D60096





More information about the llvm-commits mailing list