[PATCH] D60118: [AArch64][AsmParser] Fix .arch_extension directive parsing

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 05:27:13 PDT 2019


SjoerdMeijer added a comment.

This change looks also fine to me.
>From a quick grep in the test directory, looks like we don't have many tests for the .arch_extension directive. I.e., I see only one, for the simd directive. I think that confirms my suspicion that we tend to forget to add tests/support for the .arch_extension directive when we upstream new architecture support. So, sorry to be a pain here, but while you're add it, my request would be to add tests for some other architecture extensions that we are missing. For example, `rasv8_4` might be an interesting one because it has an underscore in it. Looks like the refactoring in D54633 <https://reviews.llvm.org/D54633> introduced new extensions that we could test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60118/new/

https://reviews.llvm.org/D60118





More information about the llvm-commits mailing list