[PATCH] D60042: [llvm-objcopy] Add --prefix-alloc-sections

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks for the patch. Before this goes in, I'd like to ask one question:

Does GNU objcopy do anything with relocation sections to sections with changed names. I suspect that it renames them to match, but I don't think this patch does that.



================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:179-180
       Config.BuildIdLinkOutput || !Config.SplitDWO.empty() ||
       !Config.SymbolsPrefix.empty() || !Config.AddSection.empty() ||
+      !Config.AllocSectionsPrefix.empty() ||
       !Config.DumpSection.empty() || !Config.KeepSection.empty() ||
----------------
Nit: It would probably make sense for this to swap with Config.AddSection.empty() to match the member order.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:505
   Config.SymbolsPrefix = InputArgs.getLastArgValue(OBJCOPY_prefix_symbols);
+  Config.AllocSectionsPrefix = InputArgs.getLastArgValue(OBJCOPY_prefix_alloc_sections);
 
----------------
Nit: this line hasn't been clang-formatted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60042/new/

https://reviews.llvm.org/D60042