[PATCH] D59942: [DebugInfo] Track multiple registers in DbgEntityHistoryCalculator

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 03:49:31 PDT 2019


dstenb marked 2 inline comments as done.
dstenb added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:161
   if (HistMap.startDbgValue(Var, DV, NewIndex)) {
+    DenseMap<unsigned, bool> TrackedRegs;
+
----------------
aprantl wrote:
> Should this be a SmallDenseMap?
Sorry, yes, this was totally overkill. For example, in a RelWithDebInfo+asan build the maximum size of the map was 11, and in 99.98% of the cases the size of the map was less than or equal 2.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59942/new/

https://reviews.llvm.org/D59942





More information about the llvm-commits mailing list