[PATCH] D55423: [LLD][ELF] - A fix for "linker script assignment loses relative nature of section" bug.

Tue Apr 2 03:38:35 PDT 2019

nickdesaulniers added inline comments.
Herald added subscribers: jdoerfert, MaskRay.

================
Comment at: ELF/Relocations.cpp:387-388
+  // They always can be computed as a link time constant.
+  if (Sym.ScriptDefined)
+    return true;
+
----------------
@peter.smith suggested that just this part of this patch is what I need in order to link an arm64 Linux kernel with KASLR enabled with LLD (https://bugs.llvm.org/show_bug.cgi?id=39810#c11).

I was able to confirm that this change was all that I needed to link a bootable kernel image.

Can I please have just this change split out of the patch?  Surely this part is less controversial?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55423/new/

https://reviews.llvm.org/D55423