[PATCH] D60062: Enforce StackID definition in PEI

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 02:43:30 PDT 2019


sdesmalen marked an inline comment as done.
sdesmalen added a comment.

Thanks!



================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:295-299
+  // All other SPGRs must be allocated on the default stack, so reset
+  // the stack ID.
+  for (unsigned i = MFI.getObjectIndexBegin(), e = MFI.getObjectIndexEnd();
+       i != e; ++i)
+    MFI.setStackID(i, 0);
----------------
arsenm wrote:
> I'm curious how you ended up finding this?
Without this change I ended up with several unit test failures:
```
    LLVM :: CodeGen/AMDGPU/control-flow-fastregalloc.ll
    LLVM :: CodeGen/AMDGPU/si-spill-sgpr-stack.ll
    LLVM :: CodeGen/AMDGPU/spill-m0.ll
    LLVM :: CodeGen/AMDGPU/spill-wide-sgpr.ll```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60062/new/

https://reviews.llvm.org/D60062





More information about the llvm-commits mailing list