[PATCH] D59780: Support Intel Control-flow Enforcement Technology

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 21:47:30 PDT 2019


ruiu marked an inline comment as done.
ruiu added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:317
+  write32(Buf + 24, Config->X86Features);            // Feature flags
+  write32(Buf + 28, 0);                              // Padding
+}
----------------
xiangzhangllvm wrote:
> Here may waste 4 bytes of code size in  32-bit machine.
Wasting 4 bytes is I think completely acceptable, but I think this is a correctness issue. I'll fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59780/new/

https://reviews.llvm.org/D59780





More information about the llvm-commits mailing list