[PATCH] D59986: [ELF] Respect NonAlloc when copying flags from the previous sections
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 1 21:22:03 PDT 2019
ruiu added a comment.
I don't think I understand the logic. So the rule you said is that, if a section is empty, its section attribute is copied from the previous (non-empty) section. Therefore, if the previous section is SHF_ALLOC, the empty section would have SHF_ALLOC, and vice versa. But you are doing more than copying section attributes -- nullifying only SHF_ALLOC using other bits. Why?
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59986/new/
https://reviews.llvm.org/D59986
More information about the llvm-commits
mailing list