[PATCH] D58951: [compiler-rt][tests] Improve handling with non-default toolchains

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added inline comments.


================
Comment at: cmake/config-ix.cmake:202
     endif()
+    list(APPEND ${cflags_out} ${COMPILER_RT_TOOLCHAIN_CFLAGS})
     string(REPLACE ";" " " ${cflags_out} "${${cflags_out}}")
----------------
pzheng wrote:
> Why don't we use COMPILER_RT_TEST_COMPILER_CFLAGS here instead of COMPILER_RT_TOOLCHAIN_CFLAGS? It seems to me that using COMPILER_RT_TEST_COMPILER_CFLAGS is a little more consistent with the usage in the if branch above.
The `if` branch above is a cross-compile only case. It is the exception rather than the rule here.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58951/new/

https://reviews.llvm.org/D58951