[PATCH] D60071: [AMDGPU] Add more test cases of D59608.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 17:20:00 PDT 2019


hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/ds-sub-offset.ll:24-26
+; CLAMPBIT-LABEL: {{^}}write_ds_sub0_offset0_global_clamp_bit:
+; CLAMPBIT: v_sub_u32
+; CLAMPBIT: s_endpgm
----------------
arsenm wrote:
> You don't need the new, special label for this
Won't be better to give more clear hint on why that test is added?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60071/new/

https://reviews.llvm.org/D60071





More information about the llvm-commits mailing list