[PATCH] D60085: Add an optional list of blocks to avoid when looking for a path in isPotentiallyReachable.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 17:06:06 PDT 2019


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

LGTM, modulo one nit. Thank you!



================
Comment at: llvm/lib/Analysis/CFG.cpp:168
+      Outer = getOutermostLoop(LI, BB);
+      if (LoopsWithHoles.count(Outer))
+        Outer = nullptr;
----------------
Could you comment the reasoning behind this for those not familiar with this code, to make it clear why this makes sense?
e.g.: "If Outer is found, we skip straight to the exit blocks below. Set it to nullptr here, to go the slow route and process BB's successors."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60085/new/

https://reviews.llvm.org/D60085





More information about the llvm-commits mailing list