[PATCH] D60070: [LLD][COFF] Move type merging structures out of PDB.cpp. NFC
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 1 16:59:21 PDT 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: COFF/TypeMerger.h:20
+
+struct TypeMerger {
+ TypeMerger(llvm::BumpPtrAllocator &Alloc)
----------------
This thing actually has methods, and maybe one day it will have private members, so let's make it a class:
https://llvm.org/docs/CodingStandards.html#use-of-class-and-struct-keywords
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60070/new/
https://reviews.llvm.org/D60070
More information about the llvm-commits
mailing list