efriedma added a comment. Yes, please refactor the code. We define a bunch of helpers in ARMBaseInstrInfo.h; that's probably fine. Looks fine otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60090/new/ https://reviews.llvm.org/D60090