[PATCH] D60008: Use binary write mode in WriteToFile function to avoid appended \r characters on Windows

[tuktuk via Phabricator via llvm-commits]

tuktuk added a comment.

Looks good to me! Here are the results without / with patch.

  D:\llvm-project\compiler-rt> python ..\build\Release\bin\llvm-lit.py --param build_config=x64 --param build_mode=Release --param llvm_site_config=../build/test/lit.site.cfg test\fuzzer\reload.test
  llvm-lit.py: D:/llvm-project/compiler-rt/test/fuzzer/lit.cfg:32: note: lsan feature unavailable
  llvm-lit.py: D:/llvm-project/compiler-rt/test/fuzzer/lit.cfg:39: note: msan feature unavailable
  llvm-lit.py: D:/llvm-project/compiler-rt/test/fuzzer/lit.cfg:57: note: linux feature unavailable
  -- Testing: 1 tests, single process --
  FAIL: libFuzzer :: reload.test (1 of 1)
  Testing Time: 25.05s
  ********************
  Failing Tests (1):
      libFuzzer :: reload.test
  
    Unexpected Failures: 1
  
  D:\llvm-project\compiler-rt> python ..\build\Release\bin\llvm-lit.py --param build_config=x64 --param build_mode=Release --param llvm_site_config=../build/test/lit.site.cfg test\fuzzer\reload.test
  llvm-lit.py: D:/llvm-project/compiler-rt/test/fuzzer/lit.cfg:32: note: lsan feature unavailable
  llvm-lit.py: D:/llvm-project/compiler-rt/test/fuzzer/lit.cfg:39: note: msan feature unavailable
  llvm-lit.py: D:/llvm-project/compiler-rt/test/fuzzer/lit.cfg:57: note: linux feature unavailable
  -- Testing: 1 tests, single process --
  PASS: libFuzzer :: reload.test (1 of 1)
  Testing Time: 9.71s
    Expected Passes    : 1

Execution time is always similar with multiple tries, I am not sure why it takes longer to fail without patch than to succeed with patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60008/new/

https://reviews.llvm.org/D60008