[PATCH] D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot.

[Taewook Oh via Phabricator via llvm-commits]

twoh created this revision.
twoh added reviewers: danielcdh, wmi.
Herald added subscribers: jdoerfert, hiraditya, eraman, javed.absar.
Herald added a project: LLVM.

As we're interested in the "callsite" hotness, not the hotness of the inlined function itself, it makes more sense to check entry sample count rather than the total sample count. Also, considering that PSI histogram is based on the execution cound of each individual line, I think `PSI->isHotCount` should be invoked with a single instruction/line profile count, not with an aggregated count for a function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60086

Files:
  llvm/lib/Transforms/IPO/SampleProfile.cpp
  llvm/test/Transforms/SampleProfile/Inputs/cold-callsite.prof
  llvm/test/Transforms/SampleProfile/Inputs/inline.compactbinary.afdo
  llvm/test/Transforms/SampleProfile/Inputs/inline.prof
  llvm/test/Transforms/SampleProfile/Inputs/warm-inline-instance.prof
  llvm/test/Transforms/SampleProfile/cold-callsite.ll
  llvm/test/Transforms/SampleProfile/compact-binary-profile.ll
  llvm/test/Transforms/SampleProfile/warm-inline-instance.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60086.193145.patch
Type: text/x-patch
Size: 5131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190401/05a9888b/attachment.bin>