[PATCH] D60081: [COFF] Fix delay import directory iterator

Joseph Tremoulet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 11:13:29 PDT 2019


JosephTremoulet added a comment.

I'm not sure how to update the tests for this change.  Ideally I'd change test/tools/llvm-readobj/imports.test to use an input that has multiple delay-load DLL references.  The inputs for that are (binary) coff files test/tools/llvm-readobj/Inputs/imports.exe.coff-x86-64 and test/tools/llvm-readobj/Inputs/imports.exe.coff-i386.  @ruiu , do we have sources for those binaries checked in or otherwise available somewhere?  Should I just generate new ones with similar import lists?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60081/new/

https://reviews.llvm.org/D60081





More information about the llvm-commits mailing list