[PATCH] D60056: Hoist/sink malloc/free's in LICM.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

A couple of quick comments.
Would you mind splitting the cleanups and bug fix (which will be straightforward to approve) and rebase this on top of that?



================
Comment at: llvm/include/llvm/Analysis/LoopAllocationInfo.h:29
+/// This analysis stores information about allocation and deallocation calls
+/// where the pointer is only live within the loop.
+///
----------------
Could you include the comment from the description here? "This analysis is tightly coupled to the internal implementation of the LICM transform."


================
Comment at: llvm/test/Transforms/LICM/allocs.ll:2
+; RUN: opt -S -licm < %s | FileCheck %s
+
+declare i8* @malloc(i32)
----------------
Could you also add a RUN line with -enable-mssa-loop-dependency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60056/new/

https://reviews.llvm.org/D60056