[PATCH] D60026: ELF: Perform per-section .ARM.exidx processing during combineEhFrameSections(). NFCI.

Mon Apr 1 10:43:37 PDT 2019

pcc added a comment.

In D60026#1449098 <https://reviews.llvm.org/D60026#1449098>, @peter.smith wrote:

> I'm happy to make the change. One minor reservation is that from combineEHSections to ARMExidxSections::finalize() the section will report its size as 0 and each individual ARMExidx InputSection won't have a parent. To the best of my knowledge this doesn't matter right now as nothing depends on these being set during that time. It may give someone a surprise in the future though.

It's normal for synthetic section sizes to not be fixed until the call to finalizeContents(), e.g. EhFrameSection: http://llvm-cs.pcc.me.uk/tools/lld/ELF/SyntheticSections.cpp#505

I believe that the sections already don't have parents until the call to finalizeContents() because the parents are created during processSectionCommands/addOrphanSections.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60026/new/

https://reviews.llvm.org/D60026