[PATCH] D60042: [llvm-objcopy] Add --prefix-alloc-sections

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/prefix-alloc-sections.test:15
+    Flags:           [  ]
+    Content:        "c3c3c3c3"
+  - Name:            .test2
----------------
section content seems irrelevant to this test, so I think you can just remove content/--section-data


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:612
 
+  if (!Config.AllocSectionsPrefix.empty()) {
+    for (auto &Sec : Obj.sections()) {
----------------
Typical llvm style is to only include braces if there is more than one statement, i.e. this should just be:

```
  if (!Config.AllocSectionsPrefix.empty())
    for (auto &Sec : Obj.sections())
      if ((Sec.Flags & SHF_ALLOC) != 0)
        Sec.Name = (Config.AllocSectionsPrefix + Sec.Name).str();
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60042/new/

https://reviews.llvm.org/D60042