[PATCH] D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header .
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 1 08:39:52 PDT 2019
DiggerLin updated this revision to Diff 193097.
DiggerLin marked 9 inline comments as done.
DiggerLin edited the summary of this revision.
DiggerLin added a comment.
April:
1. added some blank line and deleted some blank line as suggest.
2. deleted some header files #include "llvm/ObjectYAML/YAML.h"
#include "llvm/Support/YAMLTraits.h"
#include <cstdint>
from xcoffyaml.cpp
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59419/new/
https://reviews.llvm.org/D59419
Files:
llvm/include/llvm/Object/XCOFFObjectFile.h
llvm/lib/Object/XCOFFObjectFile.cpp
Index: llvm/lib/Object/XCOFFObjectFile.cpp
===================================================================
--- llvm/lib/Object/XCOFFObjectFile.cpp
+++ llvm/lib/Object/XCOFFObjectFile.cpp
@@ -157,7 +157,7 @@
return relocation_iterator(RelocationRef());
}
-void XCOFFObjectFile::moveRelocationNext(DataRefImpl &Rel) const {
+void XCOFFObjectFile::moveRelocationNext(DataRefImpl &Rel) const {
llvm_unreachable("Not yet implemented!");
return;
}
@@ -240,7 +240,7 @@
XCOFFObjectFile::XCOFFObjectFile(MemoryBufferRef Object, std::error_code &EC)
: ObjectFile(Binary::ID_XCOFF32, Object) {
-
+
// Current location within the file.
uint64_t CurPtr = 0;
Index: llvm/include/llvm/Object/XCOFFObjectFile.h
===================================================================
--- llvm/include/llvm/Object/XCOFFObjectFile.h
+++ llvm/include/llvm/Object/XCOFFObjectFile.h
@@ -40,7 +40,7 @@
// Unix time value, value of 0 indicates no timestamp.
// Negative values are reserved.
support::big32_t TimeStamp;
-
+
support::ubig32_t SymbolTableOffset; // File offset to symbol table.
support::big32_t NumberOfSymTableEntries;
support::ubig16_t AuxHeaderSize;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59419.193097.patch
Type: text/x-patch
Size: 1195 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190401/521e3434/attachment.bin>
More information about the llvm-commits
mailing list