[PATCH] D60043: [FileCheck] Fix FileCheck.cpp compilation on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D60043#1449881 <https://reviews.llvm.org/D60043#1449881>, @jdenny wrote:

>




> I'm not working on the affected platform, so I haven't confirmed the problem.  Why doesn't it affect others?

Unlike other platforms (e.g. glibc-based or the BSDs), Solaris has two specializations of std::log10 in its <math.h>, e.g.

  	inline float log10(float __X) { return __log10f(__X); }
  	inline long double log10(long double __X) { return __log10l(__X); }

This is allowed by ISO C++, but not required AFAIU.

> Regardless, the solution should be harmless, so LGTM if it helps.

Thanks.  FWIW, I'd also tried a build on `x86_64-pc-linux-gnu` without problems or regressions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60043/new/

https://reviews.llvm.org/D60043