[PATCH] D60048: [InstCombine] eliminate commuted select-shuffles + binop (PR41304)

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked 2 inline comments as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1429
+    // TODO: Allow arbitrary shuffles by shuffling after binop?
+    //       That might be legal, but we have to be deal with poison.
+    if (LShuf->isSelect() && !LShuf->getMask()->containsUndefElement() &&
----------------
xbolva00 wrote:
> typo?
Yep - fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60048/new/

https://reviews.llvm.org/D60048