[PATCH] D60057: [llvm-exegesis] Handle CMOV's OPERAND_COND_CODE OperandType
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 1 04:36:10 PDT 2019
courbet added a comment.
Thanks Roman. I only have a comment regarding documentation.
================
Comment at: tools/llvm-exegesis/lib/Target.h:105
+ virtual void randomizeMCOperand(const Instruction &Instr, const Variable &Var,
+ llvm::MCOperand &AssignedValue,
----------------
This would need some documentation, e.g.
```
// Assigns a random operand of the right type to variable Var. The default implementation only handles generic operand types. The target is responsible for handling any operand starting from OPERAND_FIRST_TARGET.
```
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60057/new/
https://reviews.llvm.org/D60057
More information about the llvm-commits
mailing list