[PATCH] D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5).

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 02:11:44 PDT 2019


courbet added a comment.

> Could that be the reason for the regression ?

Though I cannot run callgrind, I had a look at the code with/without 356550. Before the change, I see a lot of small constant-size calls to bcmp (~20 of them), e.g.:

  leaq -0xa0(%rbp), %rbx
  ...
  movl $0x20, %edx          
  movq %rbx, %rdi           
  leaq -0xe0(%rbp), %rsi    
  callq 0x1954c7            

After the change, these are inlined:

  movdqa -0x80(%rbp), %xmm0 
  movdqa -0x70(%rbp), %xmm1 
  pcmpeqb -0xd0(%rbp), %xmm1
  pcmpeqb -0xe0(%rbp), %xmm0
  pand %xmm1, %xmm0         
  pmovmskb %xmm0, %ecx      
  cmpl $0xffff, %ecx        




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56593/new/

https://reviews.llvm.org/D56593





More information about the llvm-commits mailing list